Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: Add reporting fields to activitylog config endpoint #20086

Merged
merged 6 commits into from Apr 12, 2023
Merged

api: Add reporting fields to activitylog config endpoint #20086

merged 6 commits into from Apr 12, 2023

Conversation

mpalmi
Copy link
Contributor

@mpalmi mpalmi commented Apr 11, 2023 •
edited

This PR adds the internal reporting state to the
internal/counters/config read endpoint for use by the UI:

  • reporting_enabled
  • billing_start_timestamp

@mpalmi
core/activity: Add reporting configs to endpoint
63114f7 
This PR adds the internal reporting state to the
`internal/counters/config` read endpoint:
* reporting_enabled
* billing_start_time

These fields are read-only and will return logical.ErrInvalidRequest if
they are included in an Update payload.
@mpalmi mpalmi added the backport/1.13.x Backport changes to `release/1.13.x` label Apr 11, 2023
@mpalmi mpalmi added this to the 1.13.2 milestone Apr 11, 2023
@mpalmi mpalmi changed the title core/activity: Add reporting configs to endpoint api: Add reporting fields to activitylog config endpoint Apr 11, 2023
@mpalmi mpalmi requested a review from zofskeez April 11, 2023 17:57
zofskeez
zofskeez reviewed Apr 11, 2023
View reviewed changes
Copy link
Contributor

@zofskeez zofskeez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This should be all we need on the frontend for the UI updates.

hghaf099
hghaf099 reviewed Apr 11, 2023
View reviewed changes
Copy link
Contributor

@hghaf099 hghaf099 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I asked a couple of questions just to gain more context, otherwise, it looks good.

vault/logical_system_activity.go Outdated Show resolved Hide resolved
vault/logical_system_activity.go Outdated Show resolved Hide resolved
vault/census.go Show resolved Hide resolved
@mpalmi mpalmi requested a review from yhyakuna as a code owner April 11, 2023 21:55
@mpalmi mpalmi requested a review from hghaf099 April 12, 2023 15:30
hghaf099
hghaf099 approved these changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@hghaf099 hghaf099 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the discussions!

@mpalmi mpalmi merged commit 05ba6bb into main Apr 12, 2023
89 checks passed
@mpalmi mpalmi deleted the activity-config-reporting-fields branch April 12, 2023 16:02
Closed
This was referenced Jun 13, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxb maxb maxb left review comments

@zofskeez zofskeez zofskeez left review comments

@hghaf099 hghaf099 hghaf099 approved these changes

@raskchanky raskchanky Awaiting requested review from raskchanky

@miagilepner miagilepner Awaiting requested review from miagilepner

@hellobontempo hellobontempo Awaiting requested review from hellobontempo

@hashishaw hashishaw Awaiting requested review from hashishaw

@yhyakuna yhyakuna Awaiting requested review from yhyakuna

Assignees
No one assigned
Labels
backport/1.13.x Backport changes to `release/1.13.x`
Projects
None yet
Milestone
1.13.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mpalmi @maxb @zofskeez @hghaf099