Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimum_retention_months to config endpoint #20150

Merged
merged 2 commits into from Apr 13, 2023

Conversation

mpalmi
Copy link
Contributor

@mpalmi mpalmi commented Apr 13, 2023

This PR cleans up the expected results from the last config endpoint update and adds a new field for use in the UI.

Changelog to come.

@mpalmi mpalmi added this to the 1.14 milestone Apr 13, 2023
@mpalmi
Copy link
Contributor Author

mpalmi commented Apr 13, 2023

For some context, this is needed for #20125 to move away from a static error message. see: #20125 (review)

@mpalmi mpalmi enabled auto-merge (squash) April 13, 2023 18:21
Copy link
Contributor

@zofskeez zofskeez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

@mpalmi mpalmi merged commit 002a59a into main Apr 13, 2023
87 of 88 checks passed
@mpalmi mpalmi deleted the activity-config-min-retention-months branch April 13, 2023 18:37
mpalmi added a commit that referenced this pull request Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants