Return OCSP errors on cert auth login failures #20234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
| } | ||
|
|
||
| if matches { |
There was a problem hiding this comment.
Could we add an additional protection matches && err == nil, just in case something returned a true, err which used to short-circuit failure in the past, we'd return the trustedNonCA now.
There was a problem hiding this comment.
Sure. While we're here, what's your thoughts on the second iteration? Here, we build up matches, but we only ever return the first element from it... Should we mirror this behavior, and avoid checking all the chains, given the first (valid) match will succeed the request anyways...?
There was a problem hiding this comment.
Sure sounds okay to me.
cipherboy
force-pushed
the
cipherboy-return-cert-auth-ocsp-errors
branch
from
4dfc767
to
26321f4
Compare
Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
cipherboy
force-pushed
the
cipherboy-return-cert-auth-ocsp-errors
branch
from
26321f4
to
92d613a
Compare
Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
stevendpclark
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This returns OCSP validation errors (that aren't simply a revoked certificate) to the login client, hopefully helping them to understand why their request was rejected (if by OCSP or otherwise).
We make an attempt to deduplicate these errors.