Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small fixes for OpenAPI display attributes #20285

Merged
merged 5 commits into from Apr 21, 2023
Merged

Small fixes for OpenAPI display attributes #20285

merged 5 commits into from Apr 21, 2023

Conversation

averche
Copy link
Contributor

@averche averche commented Apr 20, 2023

  • Switching the "log-in" in display attributes to "login" to be consistent with other plugins
  • Removing "auth" in aws-rotate-root-credentials since it does not need disambiguation.

@averche averche requested review from a team April 20, 2023 23:12
@averche averche added this to the 1.14 milestone Apr 20, 2023
@averche averche requested review from a team and removed request for a team April 20, 2023 23:14
dhuckins
dhuckins approved these changes Apr 21, 2023
View reviewed changes
changelog/20285.txt Outdated Show resolved Hide resolved
@averche @dhuckins
Update changelog/20285.txt
f1e8fd4 
Co-authored-by: Daniel Huckins <dhuckins@users.noreply.github.com>
@averche averche enabled auto-merge (squash) April 21, 2023 16:35
@averche averche merged commit 0311096 into main Apr 21, 2023
89 checks passed
@averche averche deleted the fix-display-attrs branch April 21, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhuckins dhuckins dhuckins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.14
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@averche @dhuckins