command/server: add support to write pprof files to the filesystem via SIGUSR2 #20609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonodonnell
changed the title
raskchanky
reviewed
May 16, 2023
raskchanky
approved these changes
May 17, 2023
This was referenced May 17, 2023
jasonodonnell
added a commit
that referenced
this pull request
May 17, 2023
…a SIGUSR2 (#20609) * core/server: add support to write pprof files to the filesystem via SIGUSR2 * changelog * Fix filepath join * Use core logger * Simplify logic * Break on error
jasonodonnell
added a commit
that referenced
this pull request
May 17, 2023
…a SIGUSR2 (#20609) * core/server: add support to write pprof files to the filesystem via SIGUSR2 * changelog * Fix filepath join * Use core logger * Simplify logic * Break on error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support to dump pprof outputs to the filesystem when
VAULT_PPROF_WRITE_TO_FILEand optionallyVAULT_PPROF_FILE_PATHset on the Vault process. This is very useful in situations where HTTP handlers are unresponsive and we cannot use the sys/pprof endpoints. I put this behind an environment variable because files are generated each time there's a SIGUSR2 signal to avoid unintentionally generating a lot of files.