VAULT-5094: Deal with identity_policies Set to nil in Secret Data Field #20636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VioletHynes
approved these changes
May 18, 2023
| t.Errorf("err was not nil, got %v", err) | ||
| } | ||
|
|
||
| // Verify that s.Data["policies"] are properly processed |
There was a problem hiding this comment.
I like this way of structuring bits of a test! Makes things a lot easier to understand at a glance. I might steal this :)
marcboudreau
deleted the
marcboudreau/VAULT-5094/fix-error-when-identity-policies-are-nil
branch
marcboudreau
added
backport/1.11.x
backport/1.13.x
This was referenced May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
vault logincommand is executed and a valid token that has associated Identity Policies in Namespaces other than the current namespace, an error is reported. This is due to the fact that the Vault CLI could not process the response from the Vault server for the Token Lookup request. Specifically, the identity_policies key in the response is set tonil. The Vault CLI code uses code (that has been fixed in this PR) that expects that either the identity_policies key to be absent in the response or present and set to either a string slice or a slice of values that can be casted to the string type.This minor fix allows that code to deal with the identity_policies key being set to
nilin the same manner as if it was absent.