Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade vault-plugin-secrets-ad to v0.16.0 #20750

Merged
merged 3 commits into from
May 24, 2023

Conversation

vinay-gopalan
Copy link
Contributor

Updates vault-plugin-secrets-ad to v0.16.0

Steps:

go get github.com/hashicorp/vault-plugin-secrets-ad@v0.16.0
go mod tidy

@vinay-gopalan vinay-gopalan requested a review from a team May 24, 2023 17:55
@vinay-gopalan vinay-gopalan changed the title upgrade github.com/hashicorp/vault-plugin-secrets-ad to v0.16.0 upgrade vault-plugin-secrets-ad to v0.16.0 May 24, 2023
Copy link
Contributor Author

@vinay-gopalan vinay-gopalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Messed up the branch name w/ the wrong plugin (auth-alicloud instead of secrets-ad... 😅) happy to reopen a different PR on a branch with the right name if folks think it's warranted, but I can also make doubly sure to delete the branch after this PR is merged

Copy link
Contributor

@swenson swenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Branch names are like lost, like tears in the rain.

@vinay-gopalan
Copy link
Contributor Author

Added a changelog as well

@vinay-gopalan vinay-gopalan merged commit b5acdc3 into main May 24, 2023
87 checks passed
@vinay-gopalan vinay-gopalan deleted the update-plugin-vault-plugin-auth-alicloud-v0.16.0 branch May 24, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants