Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce high privilege namespace (administrative namespace) #21215

Merged
merged 1 commit into from Jul 6, 2023

Conversation

biazmoreira
Copy link
Contributor

Full functionality only works in enterprise. This adds the core implementation pieces needed.

@biazmoreira biazmoreira added backport/1.13.x Backport changes to `release/1.13.x` core Issues and Pull-Requests specific to Vault Core labels Jun 14, 2023
@biazmoreira biazmoreira added this to the 1.13.4 milestone Jun 14, 2023
@@ -0,0 +1,4 @@
```release-note:change
core/namespace (enterprise): Introduce the concept of high-privilege namespace (administrative namespace),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering, as the code change universally uses the term "administrative namespace", maybe it would be clearer to stick with that terminology throughout rather than introducing "high-privilege namespace" as a synonym as well?

Copy link
Contributor

@kubawi kubawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cinthiaconti cinthiaconti modified the milestones: 1.13.4, 1.13.5 Jun 16, 2023
@biazmoreira biazmoreira force-pushed the biazmoreira/high-privilege-namespace branch 5 times, most recently from d2c23b5 to ed9bd0d Compare July 5, 2023 08:51
@biazmoreira biazmoreira force-pushed the biazmoreira/high-privilege-namespace branch 2 times, most recently from 8dfbfbd to e5cea2c Compare July 5, 2023 13:44
@biazmoreira biazmoreira added the backport/1.14.x Backport changes to `release/1.14.x` label Jul 5, 2023
@biazmoreira biazmoreira force-pushed the biazmoreira/high-privilege-namespace branch 2 times, most recently from f151e24 to dfb0d44 Compare July 5, 2023 14:40
@biazmoreira biazmoreira force-pushed the biazmoreira/high-privilege-namespace branch from dfb0d44 to 6207e1c Compare July 5, 2023 14:41
Copy link
Contributor

@ccapurso ccapurso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

biazmoreira added a commit that referenced this pull request Jul 7, 2023
biazmoreira added a commit that referenced this pull request Jul 7, 2023
biazmoreira added a commit that referenced this pull request Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.13.x Backport changes to `release/1.13.x` backport/1.14.x Backport changes to `release/1.14.x` core Issues and Pull-Requests specific to Vault Core namespace
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants