VAULT-17227 Add paths for seal config to cache exceptions. #21223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add barrierSealConfigPath and recoverySealConfigPlaintextPath to cacheExceptionsPaths in order to avoid a race that causes some nodes to always see a nil value.
victorr
commented
Jun 14, 2023
|
|
||
| // Add barrierSealConfigPath and recoverySealConfigPlaintextPath to the cache | ||
| // exceptions to avoid unseal errors. See VAULT-17227 | ||
| "core/seal-config", |
There was a problem hiding this comment.
Rather than hard code the entries here, I could add a new method to Cache to add entries to the cacheExceptions. Should I do that?
ncabatoff
approved these changes
Jun 14, 2023
|
|
This was referenced Jun 14, 2023
victorr
added a commit
that referenced
this pull request
Jun 15, 2023
Add paths for seal config to cache exceptions. Add barrierSealConfigPath and recoverySealConfigPlaintextPath to cacheExceptionsPaths in order to avoid a race that causes some nodes to always see a nil value.
victorr
added a commit
that referenced
this pull request
Jun 15, 2023
Add paths for seal config to cache exceptions. Add barrierSealConfigPath and recoverySealConfigPlaintextPath to cacheExceptionsPaths in order to avoid a race that causes some nodes to always see a nil value. Co-authored-by: Victor Rodriguez <vrizo@hashicorp.com>
ryancragun
pushed a commit
that referenced
this pull request
Jun 16, 2023
Add paths for seal config to cache exceptions. Add barrierSealConfigPath and recoverySealConfigPlaintextPath to cacheExceptionsPaths in order to avoid a race that causes some nodes to always see a nil value.
ryancragun
pushed a commit
that referenced
this pull request
Jun 16, 2023
Add paths for seal config to cache exceptions. Add barrierSealConfigPath and recoverySealConfigPlaintextPath to cacheExceptionsPaths in order to avoid a race that causes some nodes to always see a nil value.
ryancragun
added a commit
that referenced
this pull request
Jun 16, 2023
Add paths for seal config to cache exceptions. Add barrierSealConfigPath and recoverySealConfigPlaintextPath to cacheExceptionsPaths in order to avoid a race that causes some nodes to always see a nil value. Co-authored-by: Victor Rodriguez <vrizo@hashicorp.com>
victorr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add barrierSealConfigPath and recoverySealConfigPlaintextPath to cacheExceptionsPaths in order to avoid a race that causes some nodes to always see a nil value.