Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agent: Fix agent generate-config to accept namespace #21297

Merged
merged 3 commits into from Jun 16, 2023

Conversation

averche
Copy link
Contributor

@averche averche commented Jun 15, 2023

Fixing vault agent generate-config to accept -namespace, VAULT_NAMESPACE, and other client-modifying flags.

$ export VAULT_NAMESPACE="admin"
$ vault agent generate-config -type="env-template" -path="path/without/namespace" ...

OR

$ vault agent generate-config -type="env-template" -path="path/without/namespace" -namespace="admin" ...

This addresses VAULT-17295

@averche averche added this to the 1.14.1 milestone Jun 15, 2023
@averche averche marked this pull request as ready for review June 15, 2023 23:23
@averche averche requested a review from a team as a code owner June 15, 2023 23:23
@averche averche requested review from VioletHynes, dhuckins and AnPucel and removed request for a team June 15, 2023 23:23
@averche
Copy link
Contributor Author

averche commented Jun 15, 2023

@yhyakuna FYI :)

@averche averche added the backport/1.14.x Backport changes to `release/1.14.x` label Jun 15, 2023
@averche averche merged commit 3908ec9 into main Jun 16, 2023
135 checks passed
@averche averche deleted the agent-envvar-namespace branch June 16, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.14.x Backport changes to `release/1.14.x`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants