Backport of Fix: Ensure log related settings appear in 'sanitized' config into release/1.13.x #21572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-secure-vault-core
force-pushed
the
backport/fix/config-sanitize-log-settings/friendly-peaceful-boxer
branch
from
73f835d
to
ba90830
Compare
hc-github-team-secure-vault-core
force-pushed
the
backport/fix/config-sanitize-log-settings/friendly-peaceful-boxer
branch
from
fdedf02
to
c860144
Compare
peteski22
approved these changes
Jul 5, 2023
peteski22
deleted the
backport/fix/config-sanitize-log-settings/friendly-peaceful-boxer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #21567 to be assessed for backporting due to the inclusion of the label backport/1.13.x.
The below text is copied from the body of the original PR.
I was recently made aware that new config should also be handled within
Config.Sanitized()and thereforeSharedConfig.Sanitized().#18031 and #17841 added 'log related' settings which were missed in
Sanitized(), they have now been added and a test to ensure they're returned when non-defaullt.PR will be backported to
1.13.xand1.14.x.Overview of commits