Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: PKI show missing info on generated certificate #21635

Merged
merged 8 commits into from
Jul 7, 2023

Conversation

hashishaw
Copy link
Collaborator

@hashishaw hashishaw commented Jul 6, 2023

This PR shows information from a generated certificate that was previously missing, including private_key, issuing_ca, ca_chain.

Before
View generated certificate screen - Before

After
View generated certificate screen - After

@VioletHynes VioletHynes added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jul 6, 2023
Copy link
Contributor

@kiannaquach kiannaquach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks for tackling!

Copy link
Contributor

@cipherboy cipherboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🥳

@hashishaw
Copy link
Collaborator Author

FYI @kiannaquach and @cipherboy I removed the "download each value" piece from this PR -- it turned larger than expected and to keep this backportable I'm going to address that in a different ticket 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Used to indicate a potential bug hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui
Projects
None yet
4 participants