UI: Remove logic that skips sending object if not changed #21739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashishaw
added
ui
bug
github-actions
bot
added
the
hashicorp-contributed-pr
Monkeychip
approved these changes
Jul 10, 2023
This was referenced Jul 11, 2023
Merged
Merged
sebinjohn
pushed a commit
to sebinjohn/vault
that referenced
this pull request
Aug 11, 2023
* Remove logic that skips sending object if not changed * Add changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue on the UI where editing an SSH role with
default_extensionset causes thedefault_extensionto be cleared on edit (#21571)I spot-checked all the other places where we use
attr('object')and they seem to work (create, update) fine. Usually on update forms we usePOSTwith the entire payload, so I'm not sure why this was the default behavior but if we find instances that this needs to be the case we can override those specific serializers.