Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Add missing allowed_user_ids to role form in PKI #22191

Merged
merged 6 commits into from
Aug 8, 2023

Conversation

kiannaquach
Copy link
Contributor

@kiannaquach kiannaquach commented Aug 3, 2023

Description
Add allowed_user_ids under the Additional subject fields section of Create Role in PKI
Screenshot 2023-08-03 at 8 31 47 AM

Add user_ids under the Common name field in Generate Credentials in PKI
Screenshot 2023-08-08 at 9 11 51 AM

Confirmed with crypto (Alex + Steve) that it makes sense to place the fields in these sections/areas^

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Aug 3, 2023
@kiannaquach kiannaquach added this to the 1.15 milestone Aug 3, 2023
@kiannaquach kiannaquach changed the title Add missing allowed_user_ids to role form UI: Add missing allowed_user_ids to role form in PKI Aug 3, 2023
@kiannaquach kiannaquach marked this pull request as ready for review August 3, 2023 16:27
@github-actions
Copy link

github-actions bot commented Aug 3, 2023

Build Results:
All builds succeeded! ✅

@github-actions
Copy link

github-actions bot commented Aug 3, 2023

CI Results:
All Go tests succeeded! ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants