secrets/db: improves error logs for static role rotation #22253
Conversation
github-actions
bot
added
the
hashicorp-contributed-pr
|
Build Results: |
|
CI Results: |
|
I wonder if it's worth leaving a changelog note on this as an improvement to the DB engine. |
|
Does the mount_accessor not work for identifying the backend? That is included in the logs but maybe it isn't as human friendly? EDIT: mount_accessor would not help to identify what database config and role failed rotation |
|
Should we initialize the logger with hclog.With() https://github.com/hashicorp/go-hclog/blob/f7ed9e449c8dc3102bfcb86a8bda2855e07645b8/logger.go#L190 so that all logs are consistent and we don't have to worry about missing this if we add log lines in the future? |
|
@calvn - Thanks, will add the changelog entry. @fairclothjm - Good idea. Let me see on the logger. |
|
@fairclothjm - Change to use |
austingebauer
added
backport/1.13.x
* secrets/db: improves error logs for static role rotation * use logger.With to add incremental context * adds changelog
This PR improves the error logs that can result from failed database static role rotations by including the role and database names. This will help Vault operators know where to start troubleshooting when these logs appear.
Fixes: #21433