UI: fix default values resetting form inputs #22458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r changes by updating the input value with a model's default
github-actions
bot
added
the
hashicorp-contributed-pr
hellobontempo
commented
Aug 18, 2023
| {{on "change" this.onChangeWithEvent}} | ||
| {{on "input" this.onChangeWithEvent}} |
There was a problem hiding this comment.
required for model validations that happen when the input changes (not just on submit)
hellobontempo
changed the title
|
Part of the bug fix for #8656 |
hellobontempo
changed the title
|
Build Results: |
hellobontempo
commented
Aug 19, 2023
| @@ -306,8 +306,9 @@ | |||
| disabled={{and @attr.options.editDisabled (not @model.isNew)}} | |||
| autocomplete="off" | |||
| spellcheck="false" | |||
| value={{or (get @model this.valuePath) @attr.options.defaultValue}} | |||
| value={{get @model this.valuePath}} | |||
There was a problem hiding this comment.
ember sets the @model attribute with whatever the defaultValue is - so this extra logic was redundant and causing overwrites docs
|
CI Results: |
This was referenced Aug 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the work in this PR #22243 and actually solves the issue where the model default was overwriting the input and disallowing a user to clear the input
This line is redundant because
get @model this.valuePathgrabs the model default if there was one, so this was setting it again. Ember sets a model's attribute using thedefaultValueand wherever we useFormFieldwe also pass in the@model🐛 in the gif I'm clicking
backspacebut as soon as the input is cleared the value is replaced by thedefaultValue- which is frustrating UX. For consistency the input should reflect the user's changes (which exist on the model)