Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bolt.write.time should actually be a counter, not a gauge #22468

Merged
merged 5 commits into from Aug 21, 2023
Merged

bolt.write.time should actually be a counter, not a gauge #22468

merged 5 commits into from Aug 21, 2023

Conversation

raskchanky
Copy link
Contributor

Changing this, per #22428 (comment)

@raskchanky raskchanky added the backport/1.14.x Backport changes to `release/1.14.x` label Aug 21, 2023
@raskchanky raskchanky added this to the 1.14.2 milestone Aug 21, 2023
@raskchanky raskchanky requested a review from banks August 21, 2023 16:20
@raskchanky raskchanky requested a review from a team as a code owner August 21, 2023 16:20
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Aug 21, 2023
@github-actions
Copy link

Build Results:
All builds succeeded! ✅

@github-actions
Copy link

CI Results:
All Go tests succeeded! ✅

banks
banks approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member

@banks banks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. not sure about the changelog thing though?

changelog/22468.txt Outdated Show resolved Hide resolved
website/content/docs/upgrading/upgrade-to-1.14.x.mdx Outdated Show resolved Hide resolved
@raskchanky raskchanky enabled auto-merge (squash) August 21, 2023 19:49
@raskchanky raskchanky merged commit 75eebdd into main Aug 21, 2023
100 checks passed
@raskchanky raskchanky deleted the correct-bolt-write-time-take-2 branch August 21, 2023 20:11
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@banks banks banks approved these changes

Assignees
No one assigned
Labels
backport/1.14.x Backport changes to `release/1.14.x` hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Milestone
1.14.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@raskchanky @banks