events: Enable by default, disable flag #22815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
|
Build Results: |
|
CI Results: |
swenson
force-pushed
the
vault-19325/events-by-default
branch
from
fcab3eb
to
a64cd6c
Compare
tomhjp
reviewed
Sep 7, 2023
| VaultExperimentCoreAuditEventsAlpha1 = "core.audit.events.alpha1" | ||
| VaultExperimentSecretsSyncAlpha1 = "secrets.sync.alpha1" | ||
|
|
||
| // Unused experiments. We keep them so that we don't break users who include them in their |
There was a problem hiding this comment.
I agree we should keep the experiment definition but I think we should probably generate a nice error message instead of silently ignoring - it's surprising for users if they try to enable an experiment that they think does something but it doesn't.
swenson
force-pushed
the
vault-19325/events-by-default
branch
from
a64cd6c
to
998107c
Compare
added 3 commits
September 7, 2023 11:04
The flag `events.alpha1` will no longer do anything, but we keep it to prevent breaking users who have it in their configurations or startup flags, or if it is referenced in other code.
swenson
force-pushed
the
vault-19325/events-by-default
branch
from
998107c
to
7ab8c63
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flag
events.alpha1will no longer do anything, but we keep it to prevent breaking users who have it in their configurations or startup flags, or if it is referenced in other code.