Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form Field Tooltip Alignment #22832

Merged
merged 7 commits into from
Sep 6, 2023
Merged

Conversation

zofskeez
Copy link
Contributor

@zofskeez zofskeez commented Sep 6, 2023

Form field labels with a tooltip were not aligned vertically.
image

The is-label class was updated to a flex center the content.
image

@zofskeez zofskeez added this to the 1.15 milestone Sep 6, 2023
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Sep 6, 2023
font-size: 14px;
font-weight: $font-weight-bold;
display: flex;
align-items: center;
gap: $spacing-xxs;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing to flex pulled the icon right up to the text so I added the gap in.

Copy link
Contributor

@Monkeychip Monkeychip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing a quick fix on this!

@github-actions
Copy link

github-actions bot commented Sep 6, 2023

Build Results:
All builds succeeded! ✅

@zofskeez zofskeez enabled auto-merge (squash) September 6, 2023 20:57
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

CI Results:
All Go tests succeeded! ✅

@zofskeez zofskeez merged commit 068a57c into main Sep 6, 2023
98 checks passed
@zofskeez zofskeez deleted the ui/VAULT-19790/form-field-tooltip branch September 6, 2023 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants