ui: Add version diff comparison to KV v2 #23200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
|
Build Results: |
hashishaw
reviewed
Sep 20, 2023
hashishaw
reviewed
Sep 20, 2023
| `{ \"foo\": \"bar\" }`, // eslint-disable-line no-useless-escape | ||
| 'correctly pull in the data from version 4 and compared to version 1.' | ||
| ); | ||
| assert.dom(PAGE.diff.deleted).hasText(`foo"bar"`); |
There was a problem hiding this comment.
case in point: I'd expect this to say hello"world" since the newest version is foo: bar
There was a problem hiding this comment.
yeah - I think this makes a lot of sense!
hashishaw
reviewed
Sep 20, 2023
|
CI Results: |
hellobontempo
commented
Sep 21, 2023
ui/lib/kv/addon/components/page/secret/metadata/version-diff.js
Outdated
Show resolved
Hide resolved
hellobontempo
deleted the
ui/VAULT-20160/return-version-diff-selector
branch
raymonstah
pushed a commit
that referenced
this pull request
Sep 22, 2023
* add diff route * add version diff toolbar link * finish functionality of version diff comparison * add tests * update empty state message * update selectors * wip tests * finish test * add empty state test * switch dropdowns * add changelog * add comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we had plans to remove this view from the UI, we received helpful feedback here that the diff version comparison was useful. This PR returns this view to the UI, which users can access by navigating to the
Version historytab and clickingVersion diff >in the toolbar:The diff comparison defaults to comparing the current secret version with the next latest, active (not deleted or destroyed) secret version. If the current version is deleted or destroyed an empty state message appears prompting the user to select a new secret version.