Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Policy JSON Editor Toolbar Styling Fix #23297

Merged
merged 2 commits into from Sep 26, 2023

Conversation

hellobontempo
Copy link
Contributor

@hellobontempo hellobontempo commented Sep 26, 2023

Fixes regression caused by styling changes to is-label. Caught one of them in #23120 but missed this one.


with fix:

Screenshot 2023-09-26 at 2 01 11 PM

before (toolbar is scrolled by default and upload is not visible)

Screenshot 2023-09-26 at 2 01 24 PM

@hellobontempo hellobontempo added this to the 1.15.1 milestone Sep 26, 2023
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Sep 26, 2023
@hellobontempo hellobontempo added the bug Used to indicate a potential bug label Sep 26, 2023
Copy link
Contributor

@kiannaquach kiannaquach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@github-actions
Copy link

Build Results:
All builds succeeded! ✅

@github-actions
Copy link

CI Results:
All Go tests succeeded! ✅

@hellobontempo hellobontempo added the backport/1.15.x Backport changes to `release/1.15.x` label Sep 26, 2023
@hellobontempo hellobontempo merged commit ef727ea into main Sep 26, 2023
114 checks passed
@hellobontempo hellobontempo deleted the ui/fix-json-editor-policy-toolbar branch September 26, 2023 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.15.x Backport changes to `release/1.15.x` bug Used to indicate a potential bug hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants