Add banner for when resultant-acl check fails #23503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
hashishaw
commented
Oct 4, 2023
| @@ -4,56 +4,52 @@ | |||
| ~}} | |||
|
|
|||
| {{#if (and this.licenseExpired (not this.expiredDismissed))}} | |||
| <div class="license-banner-wrapper"> | |||
There was a problem hiding this comment.
Removed wrapping div and moved it to outside all the banners (in cluster.hbs)
hashishaw
commented
Oct 4, 2023
| @autoloaded={{eq this.activeCluster.licenseState "autoloaded"}} | ||
| /> | ||
| {{/if}} | ||
| <div class="cluster-banners-wrapper"> |
There was a problem hiding this comment.
This class automatically adds margins to the child divs so that spacing is consistent
|
Build Results: |
zofskeez
approved these changes
Oct 16, 2023
ui/tests/acceptance/cluster-test.js
Outdated
Comment on lines
86
to
104
| test('shows error banner if resultant-acl check fails', async function (assert) { | ||
| const login_only = ` | ||
| path "auth/token/lookup-self" { | ||
| capabilities = ["read"] | ||
| }, | ||
| `; | ||
| await consoleComponent.runCommands([ | ||
| `write sys/policies/acl/login-only policy=${btoa(login_only)}`, | ||
| `write -field=client_token auth/token/create no_default_policy=true policies="login-only"`, | ||
| ]); | ||
| const noDefaultPolicyUser = consoleComponent.lastLogOutput; | ||
| assert.dom('[data-test-resultant-acl-banner]').doesNotExist('Resultant ACL banner does not show as root'); | ||
| await logout.visit(); | ||
| assert.dom('[data-test-resultant-acl-banner]').doesNotExist('Does not show on login page'); | ||
| await authPage.login(noDefaultPolicyUser); | ||
| assert.dom('[data-test-resultant-acl-banner]').includesText('Resultant ACL check failed'); | ||
| await click('[data-test-resultant-acl-reauthenticate]'); | ||
| assert.strictEqual(currentRouteName(), 'vault.cluster.auth', 'Reauth link goes to login page'); | ||
| }); |
hashishaw
deleted the
ui/ui/VAULT-18684/banner-when-resultant-acl-fails
branch
hashishaw
added a commit
that referenced
this pull request
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The resultant-acl endpoint is an internal endpoint that is critical for the UI to deliver an interface that shows a given user only the navigation items they have access to. However, access to this endpoint is controlled via policies, so if a GUI user does not have the default policy (which includes read access to this endpoint) the user might see navigation items that they don't actually have access to.
To alleviate confusion we are adding an alert banner when this check fails:
This check will also fail if the given user doesn't have access to the namespace, so the log in CTA will have them sign in directly to the namespace with a different user.