Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Policies Error Route #23516

Merged
merged 2 commits into from Oct 5, 2023
Merged

Policies Error Route #23516

merged 2 commits into from Oct 5, 2023

Conversation

zofskeez
Copy link
Contributor

@zofskeez zofskeez commented Oct 4, 2023

This PR adds an error route for policies to allow for the policy navigation links to show if the route transition errors. Interestingly enough the error was bubbling up to the cluster.error route which I would expect that the cluster navigation links would display but for some reason no links were rendering.

image

In any case we want the policy links to render in the case of an error so adding the error route template was necessary.

image

@zofskeez zofskeez added ui backport/1.14.x Backport changes to `release/1.14.x` backport/1.15.x Backport changes to `release/1.15.x` labels Oct 4, 2023
@zofskeez zofskeez added this to the 1.14.5 milestone Oct 4, 2023
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Oct 4, 2023
@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Build Results:
All builds succeeded! ✅

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

CI Results:
All Go tests succeeded! ✅

Copy link
Contributor

@kiannaquach kiannaquach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this Jordan 🎉

@zofskeez zofskeez merged commit cbb96b2 into main Oct 5, 2023
108 checks passed
@zofskeez zofskeez deleted the ui/VAULT-20722/policies-error-route branch October 5, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.14.x Backport changes to `release/1.14.x` backport/1.15.x Backport changes to `release/1.15.x` hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants