Add Ability to Disable Replication Status Endpoints in Listener Configuration #23547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
|
Build Results: |
|
CI Results: |
marcboudreau
force-pushed
the
marcboudreau/VAULT-19869/disable-status-paths
branch
2 times, most recently
from
13583de
to
7bbd5bb
Compare
schavis
requested changes
Oct 10, 2023
Comment on lines
205
to
207
| - `disable_replication_status_endpoints` `(bool: false)` - If set true, the | ||
| replication status endpoints will be disabled for requests sent to this | ||
| listener. |
There was a problem hiding this comment.
Suggested change
| - `disable_replication_status_endpoints` `(bool: false)` - If set true, the | |
| replication status endpoints will be disabled for requests sent to this | |
| listener. | |
| - `disable_replication_status_endpoints` `(bool: false)` - Disables replication | |
| status endpoints for the configured listener when set to `true`. |
Style correction: write in active voice, avoid "this" as a pronoun
There was a problem hiding this comment.
Thanks, this reads much better.
peteski22
reviewed
Oct 10, 2023
| @@ -133,6 +133,14 @@ func rateLimitQuotaWrapping(handler http.Handler, core *vault.Core) http.Handler | |||
| }) | |||
| } | |||
|
|
|||
| func disableReplicationStatusEndpointWrapping(h http.Handler) http.Handler { | |||
There was a problem hiding this comment.
Just needs a go doc comment here 😄
|
@schavis, I've make the edit you suggested. |
* remove arg * changelog
* ensure nodes are asked to reload audit files on SIGHUP * added changelog
* redaction should only work for TCP listeners, also fix bug that allowed custom response headers for unix listeners * fix failing test * updates from PR feedback
schavis
approved these changes
Oct 11, 2023
… to refactored parsing code
marcboudreau
deleted the
marcboudreau/VAULT-19869/disable-status-paths
branch
mladlow
reviewed
Mar 11, 2024
| @@ -0,0 +1,3 @@ | |||
| ```release-note:feature | |||
| config/listener: allow per-listener configuration setting to disable replication status endpoints. | |||
There was a problem hiding this comment.
@marcboudreau next time please use the correct new feature formatting for new features in the changelog - this also applies to #23534 and #23740. Probably there should be only a single changelog entry introducing the feature as a whole.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to parse a configuration setting in the TCP listener configuration section so that the value can be stored in the http.Request context. This will allow the enterprise version implementation of the replication status endpoints:
sys/replication/statussys/replication/dr/statussys/replication/performance/statusto react accordingly.