AWS Static Secrets: Requeue credential for rotation if initial attempt fails #23673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
kpcraig
commented
Oct 16, 2023
|
Build Results: |
|
CI Results: |
vinay-gopalan
approved these changes
Oct 16, 2023
|
@kpcraig I believe this is marked as a bug in Jira. Should we should set a Milestone and add a Changelog entry? |
kpcraig
changed the title
This timeout matches what we do in other rotation implementations
only one case, but it is the one represented by the bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes and tidies up the rotation code in the aws static roles implementation, ensuring that the mechanism correctly continues to check for rotate-ready credentials, and correctly retries credential rotation (after a period) if rotation fails at the AWS API step.