Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KV Key Whitespace Warning #23702

Merged
merged 2 commits into from Oct 17, 2023
Merged

KV Key Whitespace Warning #23702

merged 2 commits into from Oct 17, 2023

Conversation

zofskeez
Copy link
Contributor

@zofskeez zofskeez commented Oct 17, 2023 •
edited

This PR adds a warning when whitespace is detected in a key of a KV engine secret.

image
image
image

Closes #6714

@zofskeez zofskeez added this to the 1.15.1 milestone Oct 17, 2023
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Oct 17, 2023
@github-actions
Copy link

Build Results:
All builds succeeded! ✅

hellobontempo
hellobontempo approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@hellobontempo hellobontempo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding a test!

@zofskeez zofskeez merged commit 43afcd7 into main Oct 17, 2023
70 checks passed
@zofskeez zofskeez deleted the ui/VAULT-20228/kv-key-whitespace branch October 17, 2023 21:36
@zofskeez zofskeez modified the milestones: 1.15.1, 1.16.0-rc1 Oct 20, 2023
@zofskeez zofskeez added the backport/1.15.x Backport changes to `release/1.15.x` label Oct 20, 2023
zofskeez added a commit that referenced this pull request Oct 20, 2023
@zofskeez
KV Key Whitespace Warning (#23702)
46f903d 
* adds warning for kv key that contains whitespace

* adds changelog entry
@zofskeez zofskeez mentioned this pull request Oct 20, 2023
Merged
zofskeez added a commit that referenced this pull request Oct 20, 2023
@zofskeez
KV Key Whitespace Warning (#23702) (#23773)
64f9d23 
* adds warning for kv key that contains whitespace

* adds changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hellobontempo hellobontempo hellobontempo approved these changes

Assignees
No one assigned
Labels
backport/1.15.x Backport changes to `release/1.15.x` enhancement hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui
Projects
None yet
Milestone
1.15.1
Development

Successfully merging this pull request may close these issues.

Web UI does not trim leading/trailing whitespaces in a secret's key
2 participants
@zofskeez @hellobontempo