Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plugins: allow all log levels for external plugins #23771

Merged
merged 2 commits into from
Oct 20, 2023
Merged

plugins: allow all log levels for external plugins #23771

merged 2 commits into from
Oct 20, 2023

Conversation

fairclothjm
Copy link
Contributor

This fixes an issue where external plugins were not reporting logs below INFO level.

@fairclothjm fairclothjm requested review from jasonodonnell and a team October 20, 2023 16:44
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Oct 20, 2023
@fairclothjm fairclothjm added this to the 1.15.1 milestone Oct 20, 2023
Zlaticanin
Zlaticanin approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@Zlaticanin Zlaticanin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!👍

@github-actions
Copy link

Build Results:
All builds succeeded! ✅

@github-actions
Copy link

CI Results:
All Go tests succeeded! ✅

@fairclothjm fairclothjm merged commit 2e85fde into main Oct 20, 2023
108 of 109 checks passed
@fairclothjm fairclothjm deleted the plugin-logging-fix branch October 20, 2023 17:13
@fairclothjm fairclothjm removed this from the 1.15.1 milestone Oct 20, 2023
@fairclothjm
Copy link
Contributor Author

Removed 1.15.1 milestone since this is an sdk change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zlaticanin Zlaticanin Zlaticanin approved these changes

@vinay-gopalan vinay-gopalan vinay-gopalan approved these changes

@jasonodonnell jasonodonnell Awaiting requested review from jasonodonnell

Assignees
No one assigned
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-milestone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fairclothjm @Zlaticanin @vinay-gopalan