release log gate if disable-gated-logs flag is set #24280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
|
Build Results: |
|
CI Results: |
raskchanky
approved these changes
Nov 30, 2023
Co-authored-by: Josh Black <raskchanky@gmail.com>
This was referenced Dec 11, 2023
hghaf099
added a commit
that referenced
this pull request
Dec 11, 2023
* release log gate if disable-gated-logs flag is set * CL * Update changelog/24280.txt Co-authored-by: Josh Black <raskchanky@gmail.com> --------- Co-authored-by: Peter Wilson <peter.wilson@hashicorp.com> Co-authored-by: Josh Black <raskchanky@gmail.com>
hghaf099
added a commit
that referenced
this pull request
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vault wouldn’t output any logs at all on startup right now as the logs are gated to be flushed until after lot of initialization is done. This PR introduces a hidden flag which is mostly used for troubleshooting that allows to flush the logs as they become available.
Addresses https://hashicorp.atlassian.net/browse/VAULT-20508