Handle show and edit views for old KV urls #24339
Conversation
github-actions
bot
added
the
hashicorp-contributed-pr
Monkeychip
changed the title
There was a problem hiding this comment.
I still want to test the old 404 error page for all non kv v2 backend secrets routes, so I replaced with cubbyhole here.
|
Build Results: |
| if (isAddonEngine(secretEngine.type, secretEngine.version)) { | ||
| // if no secret param redirect to the create route | ||
| // if secret param they are either viewing or editing secret so navigate to the details route | ||
| return !secret | ||
| ? this.router.transitionTo('vault.cluster.secrets.backend.kv.create', secretEngine.id) | ||
| : this.router.transitionTo( | ||
| 'vault.cluster.secrets.backend.kv.secret.details', | ||
| secretEngine.id, | ||
| secret | ||
| ); | ||
| } |
There was a problem hiding this comment.
Just curious if there is a case where this route is accessed and the engine type is not kv since the isAddonEngine would return true for a few other different types. PKI came to mind but I think that's been converted to fully use the engine? It might be worth considering explicitly looking for secretEngine.type === 'kv' && secretEngine.version === 2 given the redirect routes.
There was a problem hiding this comment.
Good point. Thanks for thinking that one through 🙈 Amended.
| // for kv v2, redirect users from the old url to the new engine url (1.15.0 +) | ||
| if (secretEngine.type === 'kv' && secretEngine.version === 2) { | ||
| // if no secret param redirect to the create route | ||
| // if secret param they are either viewing or editing secret so navigate to the details route |
There was a problem hiding this comment.
Wouldn't they just be editing since this is the secret-edit route?
There was a problem hiding this comment.
So I got this from the line here. And when I log mode from cubbyhole "Create" it hits this hook and the mode is "create-root". The routing is hard to follow so I literally just went with logging to figure if I needed to catch this path here.
There was a problem hiding this comment.
Ah okay - agreed, it is hard to follow!
This PR builds off of the original LIST nested secret redirect PR.
If you navigate to an old kv v2 create, show, or edit url it will redirect you to the new kv engine url.
ex:
http://localhost:4200/ui/vault/secrets/kv-test/create/test->http://localhost:4200/ui/vault/secrets/kv-test/kv/create?initialKey=testex:
http://localhost:4200/ui/vault/secrets/kv-test/create->http://localhost:4200/ui/vault/secrets/kv-test/kv/createex:
http://localhost:4200/ui/vault/secrets/kv-test/show/my-secret->http://localhost:4200/ui/vault/secrets/kv-test/kv/my-secret/details?version=1ex:
http://localhost:4200/ui/vault/secrets/kv-test/edit/my-secret->http://localhost:4200/ui/vault/secrets/kv-test/kv/complex/details?version=1Note: I ran enterprise test locally and they passed.