Rename physical backend to storage and alias old value #2456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @sethvargo @briankassouf @vishalnayak If tests pass I'm going to simply merge this but if anyone wants to give a lookover that's great too. |
vishalnayak
approved these changes
Mar 8, 2017
sethvargo
reviewed
Mar 8, 2017
| } else { | ||
| if o := list.Filter("backend"); len(o.Items) > 0 { | ||
| if err := parseStorage(&result, o, "backend"); err != nil { | ||
| return nil, fmt.Errorf("error parsing 'backend': %s", err) |
There was a problem hiding this comment.
Hey @jefferai
Do you think we should print out a warning here (and below) telling folks that it's been renamed and will be removed in a future version?
There was a problem hiding this comment.
@sethvargo I thought about that but we don't really have that plumbed through right now. Realistically we will never actually remove this so over time people checking docs will just realize that it's called storage now and new users will always call it storage. This might be one of those "when I'm bored" things, to allow returning a warning instead of just an error, or allow sending the output stream into the config parsing function, to print an error.
algitbot
pushed a commit
to alpinelinux/aports
that referenced
this pull request
Oct 9, 2020
* fix broken web link
* add api_addr default
Vault warns at startup if not set
https://learn.hashicorp.com/tutorials/vault/getting-started-deploy
* config backend -> storage
hashicorp/vault#2456
josegonzalez
added a commit
to josegonzalez/vault
that referenced
this pull request
Dec 15, 2021
This was missing from upgrade docs and implemented in hashicorp#2456.
yhyakuna
pushed a commit
that referenced
this pull request
Dec 22, 2021
…#13451) * docs: add a note regarding the backend => storage config key aliasing This was missing from upgrade docs and implemented in #2456. * Update website/content/docs/upgrading/upgrade-to-0.7.0.mdx Co-authored-by: Loann Le <84412881+taoism4504@users.noreply.github.com> Co-authored-by: Loann Le <84412881+taoism4504@users.noreply.github.com>
heppu
pushed a commit
to heppu/vault
that referenced
this pull request
Jan 13, 2022
…hashicorp#13451) * docs: add a note regarding the backend => storage config key aliasing This was missing from upgrade docs and implemented in hashicorp#2456. * Update website/content/docs/upgrading/upgrade-to-0.7.0.mdx Co-authored-by: Loann Le <84412881+taoism4504@users.noreply.github.com> Co-authored-by: Loann Le <84412881+taoism4504@users.noreply.github.com>
joatmon08
pushed a commit
that referenced
this pull request
Jan 25, 2022
…#13451) * docs: add a note regarding the backend => storage config key aliasing This was missing from upgrade docs and implemented in #2456. * Update website/content/docs/upgrading/upgrade-to-0.7.0.mdx Co-authored-by: Loann Le <84412881+taoism4504@users.noreply.github.com> Co-authored-by: Loann Le <84412881+taoism4504@users.noreply.github.com>
qk4l
pushed a commit
to qk4l/vault
that referenced
this pull request
Feb 4, 2022
…hashicorp#13451) * docs: add a note regarding the backend => storage config key aliasing This was missing from upgrade docs and implemented in hashicorp#2456. * Update website/content/docs/upgrading/upgrade-to-0.7.0.mdx Co-authored-by: Loann Le <84412881+taoism4504@users.noreply.github.com> Co-authored-by: Loann Le <84412881+taoism4504@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.