Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit: ensure 'prefix' is supplied to socket audit backends #25004

Merged
merged 2 commits into from Jan 23, 2024
Merged

Audit: ensure 'prefix' is supplied to socket audit backends #25004

merged 2 commits into from Jan 23, 2024

Conversation

peteski22
Copy link
Contributor

No description provided.

@peteski22 peteski22 added bug Used to indicate a potential bug core/audit hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed labels Jan 23, 2024
@peteski22 peteski22 added this to the 1.15.5 milestone Jan 23, 2024
@peteski22 peteski22 marked this pull request as ready for review January 23, 2024 17:56
@peteski22 peteski22 requested a review from kubawi January 23, 2024 18:00
@peteski22 peteski22 added the backport/1.15.x Backport changes to `release/1.15.x` label Jan 23, 2024
kubawi
kubawi approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@kubawi kubawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link

Build Results:
All builds succeeded! ✅

@github-actions GitHub Actions
Copy link

CI Results:
All Go tests succeeded! ✅

@peteski22 peteski22 merged commit 58ef5fe into main Jan 23, 2024
114 of 128 checks passed
@peteski22 peteski22 deleted the peteski22/audit/socket-prefix-bug branch January 23, 2024 18:26
Merged
peteski22 added a commit that referenced this pull request Jan 23, 2024
@peteski22
Audit: ensure 'prefix' is supplied to socket audit backends (#25004)
5d265a3 
* ensure 'prefix' is supplied to socket audit backends

* changelog
peteski22 added a commit that referenced this pull request Jan 23, 2024
@hc-github-team-secure-vault-core @peteski22
Audit: ensure 'prefix' is supplied to socket audit backends (#25004) (#…
32258c0 
…25008)

* ensure 'prefix' is supplied to socket audit backends

* changelog

Co-authored-by: Peter Wilson <peter.wilson@hashicorp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kubawi kubawi kubawi approved these changes

Assignees
No one assigned
Labels
backport/1.15.x Backport changes to `release/1.15.x` bug Used to indicate a potential bug core/audit hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Milestone
1.15.5
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@peteski22 @kubawi