Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Fix copy button not working for non-string masked values #25269

Merged
merged 2 commits into from Feb 7, 2024

Conversation

hashishaw
Copy link
Collaborator

This PR fixes an issue where non-string values would not be copied from the masked input view, and would throw an error in the console like

Uncaught (in promise) Error: Assertion Failed: `hds-clipboard` modifier - `text` argument must be a string - provided: object
Successful copy

@hashishaw hashishaw added ui bug Used to indicate a potential bug labels Feb 7, 2024
@hashishaw hashishaw added this to the 1.16.0-rc1 milestone Feb 7, 2024
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Feb 7, 2024
Copy link

github-actions bot commented Feb 7, 2024

CI Results:
All Go tests succeeded! ✅

Copy link

github-actions bot commented Feb 7, 2024

Build Results:
All builds succeeded! ✅

Copy link
Contributor

@Monkeychip Monkeychip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@hashishaw hashishaw merged commit 3dd1667 into main Feb 7, 2024
30 of 31 checks passed
@hashishaw hashishaw deleted the ui/VAULT-23764/fix-copy-button-object branch February 7, 2024 20:15
@hellobontempo hellobontempo mentioned this pull request Feb 7, 2024
Monkeychip pushed a commit that referenced this pull request Feb 12, 2024
* Fix masked input copy button for non-strings

* add changelog
@hashishaw hashishaw modified the milestones: 1.16.0-rc1, 1.15.6 Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Used to indicate a potential bug hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants