Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Skip OpenAPI call for unmanaged auth methods #25364

Merged
merged 3 commits into from
Feb 14, 2024
Merged

UI: Skip OpenAPI call for unmanaged auth methods #25364

merged 3 commits into from
Feb 14, 2024

Conversation

hashishaw
Copy link
Collaborator

@hashishaw hashishaw commented Feb 12, 2024 •
edited
Loading

This PR skips the OpenAPI call on auth methods which are not managed in the UI. Resolves #24160

@hashishaw hashishaw added the ui label Feb 12, 2024
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Feb 12, 2024
@hashishaw hashishaw changed the title UI/no path help unmanaged auth methods UI/ Skip OpenAPI call for unmanaged auth methods Feb 12, 2024
@hashishaw hashishaw changed the title UI/ Skip OpenAPI call for unmanaged auth methods UI: Skip OpenAPI call for unmanaged auth methods Feb 12, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 12, 2024 •
edited
Loading

CI Results:
All Go tests succeeded! ✅

Monkeychip
Monkeychip reviewed Feb 12, 2024
View reviewed changes
Copy link
Contributor

@Monkeychip Monkeychip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any test coverage we can add for this? Might help us make sure we're covering any situations we're not considering.

@hashishaw
Copy link
Collaborator Author

Any test coverage we can add for this? Might help us make sure we're covering any situations we're not considering.

We already have test coverage that the tabs are expected on the pages where I'm removing the call, so I figured that is sufficient. But if you have ideas of other scenarios to test for this I'm open to it!

@hashishaw hashishaw marked this pull request as ready for review February 12, 2024 19:38
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 12, 2024 •
edited
Loading

Build Results:
All builds succeeded! ✅

@hashishaw hashishaw added this to the 1.14.10 milestone Feb 12, 2024
Monkeychip
Monkeychip approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@Monkeychip Monkeychip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test coverage looks good. Took a closer look and anything else seems like duplicating what we already look at. Thank you!

@hashishaw hashishaw force-pushed the ui/no-path-help-unmanaged-auth-methods branch from c6bf477 to 470822f Compare February 14, 2024 19:26
@hashishaw
Copy link
Collaborator Author

Rebased from main so I wouldn't have any merge conflicts on the backport with the inject as service import change

@hashishaw hashishaw enabled auto-merge (squash) February 14, 2024 19:27
@hashishaw hashishaw merged commit 59577f4 into main Feb 14, 2024
26 checks passed
@hashishaw hashishaw deleted the ui/no-path-help-unmanaged-auth-methods branch February 14, 2024 19:36
This was referenced Feb 14, 2024
Closed
Closed
Closed
hashishaw added a commit that referenced this pull request Feb 14, 2024
@hashishaw
UI: Skip OpenAPI call for unmanaged auth methods (#25364)
95e0e41 
* Skip fetching OpenAPI if the auth method is not managable in the UI. Fixes #24160

* remove map

* add changelog
hashishaw added a commit that referenced this pull request Feb 14, 2024
@hashishaw
UI: Skip OpenAPI call for unmanaged auth methods (#25364)
b05adcc 
* Skip fetching OpenAPI if the auth method is not managable in the UI. Fixes #24160

* remove map

* add changelog
hashishaw added a commit that referenced this pull request Feb 14, 2024
@hashishaw
UI: Skip OpenAPI call for unmanaged auth methods (#25364)
03792cf 
:q:q:
* Skip fetching OpenAPI if the auth method is not managable in the UI. Fixes #24160

* remove map

* add changelog
This was referenced Feb 14, 2024
Merged
Merged
@hashishaw hashishaw mentioned this pull request Feb 14, 2024
Merged
hashishaw added a commit that referenced this pull request Feb 14, 2024
@hashishaw
Backport UI: Skip OpenAPI call for unmanaged auth methods (#25364) (#…
186ce06 
…25429)

* Skip fetching OpenAPI if the auth method is not managable in the UI. Fixes #24160

* remove map

* add changelog
hashishaw added a commit that referenced this pull request Feb 14, 2024
@hashishaw
Backport UI: Skip OpenAPI call for unmanaged auth methods (#25364) (#…
e917f38 
…25431)
hashishaw added a commit that referenced this pull request Feb 14, 2024
@hashishaw
Backport UI: Skip OpenAPI call for unmanaged auth methods (#25364) (#…
24674da 
…25430)

* Skip fetching OpenAPI if the auth method is not managable in the UI. Fixes #24160

* remove map

* add changelog
@hellobontempo hellobontempo mentioned this pull request Mar 18, 2024
Merged
This was referenced Mar 18, 2024
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Monkeychip Monkeychip Monkeychip approved these changes

Assignees
No one assigned
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui
Projects
None yet
Milestone
1.14.10
Development

Successfully merging this pull request may close these issues.

Accessing UI at path /ui/vault/access/token/configuration creates unexpectedly large audit message
2 participants
@hashishaw @Monkeychip