VAULT-528 Fix Vault Agent being unable to render secrets with delete_version_after set. #25387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results: |
VioletHynes
commented
Feb 13, 2024
| @@ -3204,6 +3206,159 @@ auto_auth { | |||
| require.Truef(t, found, "unable to find consul-template partial message in logs", runnerLogMessage) | |||
| } | |||
|
|
|||
| // TestAgent_DeleteAfterVersion_Rendering Validates that Vault Agent | |||
| // can correctly render a secret with delete_after_version set. | |||
| func TestAgent_DeleteAfterVersion_Rendering(t *testing.T) { | |||
There was a problem hiding this comment.
Hopefully needless to say, but this test fails with an older version of consul-template (without the fix), and correctly validates the fix works.
marcboudreau
approved these changes
Feb 13, 2024
divyaac
approved these changes
Feb 13, 2024
divyaac
approved these changes
Feb 13, 2024
|
Build Results: |
VioletHynes
added a commit
that referenced
this pull request
Feb 13, 2024
…version_after set. (#25387) * VAULT-528 add test reproducing the failure that should pass after the fix * VAULT-528 Upgrade consul-template to version with the fix * VAULT-528 changelog
VioletHynes
added a commit
that referenced
this pull request
Feb 13, 2024
…ender secrets with delete_version_after set. (#25388) * VAULT-528 Fix Vault Agent being unable to render secrets with delete_version_after set. (#25387) * VAULT-528 add test reproducing the failure that should pass after the fix * VAULT-528 Upgrade consul-template to version with the fix * VAULT-528 changelog * VAULT-528 we need VersionedKVFactory on this branch * VAULT-528 typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actual fix was in consul-template (see: hashicorp/consul-template#1879). This PR adds a test to validate the fix works (the test failed before the dependency upgrade).
Resolves #9898
Resolves hashicorp/vault-k8s#176