Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VAULT-23926: Fix rollback deadlock on perf secondaries #25448

Merged
merged 7 commits into from Feb 21, 2024

Conversation

miagilepner
Copy link
Contributor

The test is in an enterprise PR.

@miagilepner miagilepner added backport/1.13.x Backport changes to `release/1.13.x` backport/1.14.x Backport changes to `release/1.14.x` backport/1.15.x Backport changes to `release/1.15.x` backport/1.16.x Backport changes to `release/1.16.x` labels Feb 15, 2024
@miagilepner miagilepner added this to the 1.14.10 milestone Feb 15, 2024
@miagilepner miagilepner requested a review from a team as a code owner February 15, 2024 17:58
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Feb 15, 2024
Copy link

github-actions bot commented Feb 15, 2024

CI Results:
All Go tests succeeded! ✅

Copy link

github-actions bot commented Feb 15, 2024

Build Results:
All builds succeeded! ✅

Copy link
Member

@banks banks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great Mia!

@miagilepner miagilepner merged commit 5f0638a into main Feb 21, 2024
84 checks passed
@miagilepner miagilepner deleted the miagilepner/VAULT-23926-rollback-deadlock branch February 21, 2024 15:38
miagilepner added a commit that referenced this pull request Feb 21, 2024
* prevent deadlock

* rollbacks not done for sync invalidate

* add check for the path before deleting

* revert sync invalidation doesn't do rollbacks

* add known issue

* changelog

* fix formatting issue
miagilepner added a commit that referenced this pull request Feb 21, 2024
* prevent deadlock

* rollbacks not done for sync invalidate

* add check for the path before deleting

* revert sync invalidation doesn't do rollbacks

* add known issue

* changelog

* fix formatting issue
miagilepner added a commit that referenced this pull request Feb 21, 2024
* prevent deadlock

* rollbacks not done for sync invalidate

* add check for the path before deleting

* revert sync invalidation doesn't do rollbacks

* add known issue

* changelog

* fix formatting issue
miagilepner added a commit that referenced this pull request Feb 21, 2024
* prevent deadlock

* rollbacks not done for sync invalidate

* add check for the path before deleting

* revert sync invalidation doesn't do rollbacks

* add known issue

* changelog

* fix formatting issue

Co-authored-by: miagilepner <mia.epner@hashicorp.com>
miagilepner added a commit that referenced this pull request Feb 21, 2024
* prevent deadlock

* rollbacks not done for sync invalidate

* add check for the path before deleting

* revert sync invalidation doesn't do rollbacks

* add known issue

* changelog

* fix formatting issue

Co-authored-by: miagilepner <mia.epner@hashicorp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.13.x Backport changes to `release/1.13.x` backport/1.14.x Backport changes to `release/1.14.x` backport/1.15.x Backport changes to `release/1.15.x` backport/1.16.x Backport changes to `release/1.16.x` hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants