Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helper/metricsutil: Update usage of expfmt #25947

Merged
merged 2 commits into from
Mar 14, 2024
Merged

helper/metricsutil: Update usage of expfmt #25947

merged 2 commits into from
Mar 14, 2024

Conversation

peteski22
Copy link
Contributor

The previously exposed constants are no longer exposed, and we can use expfmt.Format instead. prometheus/common#576

Once Prometheus gets updated, the Vault dependency breaks.

Authored by @metalmatze in (#25799)

metalmatze and others added 2 commits March 6, 2024 16:08
The previous exposed constants are no longer exposed and we can use expfmt.Format instead.
prometheus/common#576
@peteski22 peteski22 requested a review from kubawi March 14, 2024 09:30
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Mar 14, 2024
@peteski22 peteski22 added pr/no-changelog pr/no-milestone and removed hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed labels Mar 14, 2024
Copy link

Build Results:
All builds succeeded! ✅

Copy link

CI Results:
All Go tests succeeded! ✅

@peteski22 peteski22 merged commit dc1e0be into main Mar 14, 2024
90 of 92 checks passed
@peteski22 peteski22 deleted the expfmt branch March 14, 2024 10:13
@jimmybigcommerce
Copy link

Wondering why this change hasn't made it into a tagged release yet?

@peteski22
Copy link
Contributor Author

peteski22 commented May 1, 2024

@jimmybigcommerce
Copy link

@peteski22
Copy link
Contributor Author

@jimmybigcommerce I believe it is part of 1.16.2.
https://github.com/hashicorp/vault/releases/tag/v1.16.2

This line appears to be the old code: https://github.com/hashicorp/vault/blob/v1.16.2/helper/metricsutil/metricsutil.go#L148

'doh' you're right I made a mistake when searching the PR number (missed the 7 from the end 🤦🏼), my apologies.

It's not not in any release as of yet, the reason is likely to be code freezes and such relating to the timing of the last release. I'd expect to see it in a future tagged release as it's part of main now.

😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants