Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: do not require sudo for GetAuth wrapper #25968

Merged
merged 2 commits into from Mar 15, 2024
Merged

api: do not require sudo for GetAuth wrapper #25968

merged 2 commits into from Mar 15, 2024

Conversation

fairclothjm
Copy link
Contributor

This PR proposes the following changes

  • remove sudo requirement for GetAuthWithContext and GetAuth API wrapper methods
  • add the missing sudo requirement to the API docs for sys/auth/:path

This should allow the TFVP to use the API wrapper and remove the sudo requirement for managing auth methods.

See

@fairclothjm fairclothjm requested a review from a team March 15, 2024 15:32
@fairclothjm fairclothjm requested a review from a team as a code owner March 15, 2024 15:32
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Mar 15, 2024
@fairclothjm fairclothjm added this to the 1.16.0 milestone Mar 15, 2024
@fairclothjm fairclothjm added the backport/1.16.x Backport changes to `release/1.16.x` label Mar 15, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 15, 2024 •
edited

CI Results:
All Go tests succeeded! ✅

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 15, 2024 •
edited

Build Results:
All builds succeeded! ✅

@fairclothjm fairclothjm enabled auto-merge (squash) March 15, 2024 15:38
@fairclothjm fairclothjm merged commit 594d304 into main Mar 15, 2024
84 checks passed
@fairclothjm fairclothjm deleted the api/auth-wrapper-no-sudo branch March 15, 2024 21:40
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinay-gopalan vinay-gopalan vinay-gopalan approved these changes

Assignees
No one assigned
Labels
backport/1.16.x Backport changes to `release/1.16.x` hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fairclothjm @vinay-gopalan