Address OCSP client caching issue #25986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The OCSP cache built into the client that is used by cert-auth would cache the responses but when pulling out a cached value the response wasn't validating properly and was then thrown away. - The issue was around a confusion of the client's internal status vs the Go SDK OCSP status integer values. - Add a test that validates the cache is now used
stevendpclark
added
bug
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results: |
|
Build Results: |
- Remove the previous lookup before revocation as now the OCSP cache works so we don't see the new revocation as we are actually leveraging the cache
stevendpclark
force-pushed
the
stevendpclark/vault-24947-fix-ocsp-cache
branch
from
77fe1c9
to
802f867
Compare
This was referenced Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OCSP cache built into the client that is used by cert-auth would cache the responses but when pulling out a cached value the response wasn't validating properly and was then thrown away. So effectively we were operating with no cache.
The issue was around a confusion of the client's internal status vs the Go SDK OCSP status integer values.