Update to new Azure code after dep update #2603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jefferai
force-pushed
the
azure-dep-update-breakage
branch
from
646a2e9
to
56de4b2
Compare
chrishoffman
approved these changes
Apr 17, 2017
vishalnayak
approved these changes
Apr 17, 2017
| if created { | ||
| err = contObj.SetPermissions(storage.ContainerPermissions{ | ||
| AccessType: storage.ContainerAccessTypePrivate, | ||
| }, 0, "") |
There was a problem hiding this comment.
Can you link to the docs where it specifies the defaults for the timeout?
There was a problem hiding this comment.
There was a problem hiding this comment.
I actually just used the code to verify this -- the code for the function has an if timeout > 0 check, so 0 is the default. Same with the string val.
chrishoffman
pushed a commit
that referenced
this pull request
Apr 18, 2017
* oss/master: Fix azure test round 2 Fix test for changed Azure changelog++ Add -self flag to token-revoke (#2596) Update revoke.html.md (#2604) Update to new Azure code after dep update (#2603) changelog++ Added "Domain" configuration parameter to Swift provider to enable V3 authentication (#2554) Fix cassandra dep breakage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.