Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect patch version #26169

Merged
merged 2 commits into from
Mar 26, 2024
Merged

Incorrect patch version #26169

merged 2 commits into from
Mar 26, 2024

Conversation

sgmiller
Copy link
Collaborator

@sgmiller sgmiller commented Mar 26, 2024 •
edited
Loading

CE was incorrectly 1.16.3, causing the ent merge to fail.

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Mar 26, 2024
mladlow
mladlow reviewed Mar 26, 2024
View reviewed changes
Copy link
Collaborator

@mladlow mladlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure this needs to be 1.16.0 but not 100% certain.

version/VERSION Outdated
1.16.1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1.16.1
1.16.0

@sgmiller can you actually reset this to 1.16.0 since we'll need to publish that again?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, good point

@sgmiller sgmiller requested a review from mladlow March 26, 2024 20:31
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 26, 2024 •
edited
Loading

CI Results: failed ❌
Failures:

Test Type Package Test Logs
standard vault/external_tests/consul_fencing_binary TestConsulFencing_PartitionedLeaderCantWrite view test results

mladlow
mladlow approved these changes Mar 26, 2024
View reviewed changes
Copy link
Collaborator

@mladlow mladlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll possibly still need to do a manual merge. I feel like I tried to fix it that way after RC3 and I wonder if I messed something up.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 26, 2024 •
edited
Loading

Build Results:
Build failed for these jobs: test:failure. Please refer to this workflow to learn more: https://github.com/hashicorp/vault/actions/runs/8442506158

@sgmiller sgmiller added this to the 1.16.0 milestone Mar 26, 2024
@sgmiller sgmiller merged commit 0c91287 into release/1.16.x Mar 26, 2024
70 of 76 checks passed
@sgmiller sgmiller deleted the sgm/correct-1.16-version branch March 26, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mladlow mladlow mladlow approved these changes

@hc-github-team-es-release-engineering hc-github-team-es-release-engineering Awaiting requested review from hc-github-team-es-release-engineering

Assignees
No one assigned
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgmiller @mladlow