Randomizing x coordinate in shamir split #2621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jefferai
reviewed
Apr 20, 2017
shamir/shamir.go
Outdated
| @@ -166,13 +167,16 @@ func Split(secret []byte, parts, threshold int) ([][]byte, error) { | |||
| return nil, fmt.Errorf("cannot split an empty secret") | |||
| } | |||
|
|
|||
| // Generate random list of x coordinates | |||
| xCoordinates := mathrand.Perm(255) | |||
There was a problem hiding this comment.
I did not know about rand.Perm -- neat!
|
LGTM. Adding @armon for an extra look since he handled the original code. |
|
Good catch. It was an efficiency change but I also forgot the original intent of the change. Back to 255. |
|
My only concern is using |
|
@chrishoffman If the permutation you get back is always consistently ordered, it makes it easy to map backwards to the actual lower bound. At the least, |
|
Thanks @armon for bringing this to my attention. It looks like I made a bad assumption about automatic seeding in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2608