Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: fixed HOME not set error #26243

Merged
merged 4 commits into from Apr 2, 2024
Merged

cli: fixed HOME not set error #26243

merged 4 commits into from Apr 2, 2024

Conversation

jasonodonnell
Copy link
Contributor

When HCP subcommands were added it created a hard dependency on HOME being configured for users. The upstream HCP lib has been slightly refactored to take a path argument and in the Vault CLI we are just ignoring home directory not set errors.

Fixes #26199.

@jasonodonnell jasonodonnell added this to the 1.16.1 milestone Apr 2, 2024
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Apr 2, 2024
@jasonodonnell jasonodonnell added the backport/1.16.x Backport changes to `release/1.16.x` label Apr 2, 2024
Copy link

github-actions bot commented Apr 2, 2024

CI Results:
All Go tests succeeded! ✅

Copy link

github-actions bot commented Apr 2, 2024

Build Results:
All builds succeeded! ✅

Copy link
Contributor

@ccapurso ccapurso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the fix!

@jasonodonnell jasonodonnell merged commit 39499e6 into main Apr 2, 2024
83 checks passed
@jasonodonnell jasonodonnell deleted the cli-home branch April 2, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.16.x Backport changes to `release/1.16.x` hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1.16.0 requires $HOME to be set
2 participants