Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Rotation Manager stubs for OSS #26360

Open
wants to merge 2 commits into
base: VAULT-21042/core-managed-rotate-poc
Choose a base branch
from
Open

Add Rotation Manager stubs for OSS #26360

wants to merge 2 commits into from

Conversation

vinay-gopalan
Copy link
Contributor

Removes rotation manager logic from Vault CE and adds OSS stubs.

@vinay-gopalan vinay-gopalan requested a review from a team as a code owner April 10, 2024 22:21
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Apr 10, 2024
@github-actions GitHub Actions
Copy link

Build Results:
Build failed for these jobs: test:failure. Please refer to this workflow to learn more: https://github.com/hashicorp/vault/actions/runs/8638599950

@github-actions GitHub Actions
Copy link

CI Results:
Failures:

Test Type Package Test Logs
builtin/credential/ldap TestBackend_basic view test results
builtin/credential/ldap TestBackend_basic_authbind view test results
builtin/credential/ldap TestBackend_basic_authbind_metadata_name view test results
builtin/credential/ldap TestBackend_basic_authbind_userfilter view test results
builtin/credential/ldap TestBackend_basic_discover view test results
builtin/credential/ldap TestBackend_basic_group_noPolicies view test results
builtin/credential/ldap TestBackend_basic_noPolicies view test results
builtin/credential/ldap TestBackend_basic_nogroupdn view test results
builtin/credential/ldap TestBackend_configDefaultsAfterUpdate view test results
builtin/credential/ldap TestLdapAuthBackend_CaseSensitivity view test results

and 39 other tests

fairclothjm
fairclothjm approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@fairclothjm fairclothjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fairclothjm fairclothjm fairclothjm approved these changes

Assignees
No one assigned
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vinay-gopalan @fairclothjm