UI: Update custom message list filters #26653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results: |
|
Build Results: |
Monkeychip
reviewed
Apr 25, 2024
Monkeychip
reviewed
Apr 25, 2024
| @action | ||
| onFilterInputChange(pageFilter) { | ||
| this.transitionToMessagesWithParams({ pageFilter }); | ||
| @task |
Monkeychip
reviewed
Apr 25, 2024
| @@ -126,10 +96,10 @@ module('Acceptance | Enterprise | config-ui/message', function (hooks) { | |||
| test('it should show an empty state when no messages are created', async function (assert) { | |||
| assert.expect(4); | |||
| await click(CUSTOM_MESSAGES.navLink); | |||
Monkeychip
approved these changes
Apr 25, 2024
hellobontempo
approved these changes
Apr 25, 2024
| data-test-filter-by-message-type | ||
| /> | ||
| <form {{on "submit" (perform this.handleSearch)}} aria-label="Filter custom message list"> | ||
| <Hds::SegmentedGroup as |S|> |
| @task | ||
| *handleSearch(evt) { | ||
| evt.preventDefault(); | ||
| const formData = new FormData(evt.target); |
There was a problem hiding this comment.
💡 today I learned about the FormData class. Is this why you don't have to manage and track the value on the form inputs in the hbs file?
There was a problem hiding this comment.
That's right! As long as we pass a name to the input, we can access the values by name from the form submit event. When we don't need to show other things based on form values or do validation on keyup, this is a simple way to handle form submits
markafarrell
pushed a commit
to markafarrell/vault
that referenced
this pull request
Apr 29, 2024
* use SegmentedGroup for custom messages list filter * Update test coverage * cleanup * add changelog * address pr comments
markafarrell
pushed a commit
to markafarrell/vault
that referenced
this pull request
Apr 29, 2024
* use SegmentedGroup for custom messages list filter * Update test coverage * cleanup * add changelog * address pr comments
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of managing the Ember 5 deprecations, the custom messages filters were causing errors in tests due to the DOM tearing down before the focus filter is able to finish running. Updating filters on type is a pattern we're moving away from, so to resolve the test failures we are replacing this filter bar with an explicit filter button.