Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs/auth/jwt: add resolved version in upgrade guide #27015

Merged
merged 5 commits into from
May 23, 2024
Merged

docs/auth/jwt: add resolved version in upgrade guide #27015

merged 5 commits into from
May 23, 2024

Conversation

fairclothjm
Copy link
Contributor

No description provided.

@fairclothjm fairclothjm added pr/no-changelog pr/no-milestone backport/1.16.x Backport changes to `release/1.16.x` labels May 14, 2024
@fairclothjm fairclothjm requested a review from a team May 14, 2024 14:58
@fairclothjm fairclothjm requested a review from a team as a code owner May 14, 2024 14:58
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label May 14, 2024
@github-actions GitHub Actions
Copy link

CI Results:
All Go tests succeeded! ✅

@github-actions GitHub Actions
Copy link

Build Results:
All builds succeeded! ✅

@fairclothjm @schavis
Update website/content/partials/known-issues/1_16-jwt_auth_config.mdx
ec16d73 
Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
@fairclothjm fairclothjm enabled auto-merge (squash) May 14, 2024 19:04
@fairclothjm fairclothjm requested a review from schavis May 15, 2024 15:21
@fairclothjm
Copy link
Contributor Author

@schavis Thanks, the requested changes have been resolved.

mladlow
mladlow reviewed May 16, 2024
View reviewed changes
Copy link
Collaborator

@mladlow mladlow left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind making this consistent with how we've added other resolutions? I haven't seen us add a separate note-style block before.

I believe for consistency we'd add to line 10 something like "This issue is addressed in Vault 1.16.2 and later" or something along those lines.

Edit: I don't think we'd typically say this as part of the "workaround" section.

@fairclothjm
Copy link
Contributor Author

Thanks @mladlow I would be happy to make the change. @schavis suggested the note-styling and I would not want to override their suggestion without approval.

@fairclothjm
Copy link
Contributor Author

@mladlow addressed in 2bef5b8

mladlow
mladlow approved these changes May 17, 2024
View reviewed changes
Copy link
Collaborator

@mladlow mladlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@schavis I've gone ahead and approved this because I think it takes into account your feedback as well, and I want to unblock @fairclothjm from merging.

@fairclothjm
Copy link
Contributor Author

Merging is blocked. I believe I require approval from @schavis since they request changes.

@fairclothjm
Copy link
Contributor Author

@schavis Hello, I am unable to merge this until I get your approval since you requested changes. Thanks!

@fairclothjm fairclothjm merged commit e8c1da8 into main May 23, 2024
31 of 32 checks passed
@fairclothjm fairclothjm deleted the docs/auth-jwt-upgrade-1.16 branch May 23, 2024 21:13
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mladlow mladlow mladlow approved these changes

@schavis schavis schavis approved these changes

Assignees
No one assigned
Labels
backport/1.16.x Backport changes to `release/1.16.x` backport/1.17.x hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog pr/no-milestone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fairclothjm @mladlow @schavis