agent: allow changing file ownership in file sink #27123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schavis
requested changes
May 23, 2024
Allow changing the ownership of the token file in file sink. Signed-off-by: Seena Fallah <seenafallah@gmail.com>
clwluvw
force-pushed
the
file-sink-ownership
branch
from
dc860fd
to
171f5b9
Compare
VioletHynes
reviewed
May 27, 2024
VioletHynes
approved these changes
May 27, 2024
|
Hi there @clwluvw ! Just one little thing before we get this merged: the linter check failed with the following: Could you make sure to add a godoc for the test, describing what it does and what it's for? Thanks :D I also need to run this by @schavis to make sure there are no outstanding requested changes. |
Signed-off-by: Seena Fallah <seenafallah@gmail.com>
|
Hi @VioletHynes - Thanks for the review. I just added the godoc for the test. |
|
Thanks! It's a holiday in some parts of the world today and I'll need to confirm with Sarah before I merge this, but I hope to get this merged soon this week :) |
schavis
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow changing the ownership of the token file in file sink.