Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdk: fix bug with returning default value from GetOk #27561

Closed
wants to merge 2 commits into from

Conversation

fairclothjm
Copy link
Contributor

@fairclothjm fairclothjm commented Jun 21, 2024

This very well may be a breaking change but I wanted to run the full Vault test suite to see what happens.

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jun 21, 2024
Copy link

github-actions bot commented Jun 21, 2024

CI Results: failed ❌
Failures:

Test Type Package Test Logs
race builtin/credential/approle TestAppRole_BoundCIDRLogin view test results
race builtin/credential/approle TestAppRole_RoleCRUD view test results
race builtin/credential/approle TestAppRole_RoleConstraints view test results
race builtin/credential/aws TestAwsEc2_RoleCrud view test results
race builtin/credential/aws TestBackend_pathIam view test results
race builtin/credential/aws TestBackend_pathRoleMixedTypes view test results
race builtin/credential/aws Test_enableIamIDResolution view test results
race builtin/credential/ldap TestLdapAuthBackend_ConfigUpgrade view test results
race builtin/logical/aws TestBackend_PathConfigRoot view test results
race builtin/logical/database TestBackend_StaticRole_Rotation_Schedule_ErrorRecover view test results

and 101 - 10 other tests

Copy link

github-actions bot commented Jun 21, 2024

Build Results:
All builds succeeded! ✅

@fairclothjm
Copy link
Contributor Author

This is indeed a breaking change!

@fairclothjm fairclothjm deleted the sdk/getok-default-value branch June 21, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant