Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document token format/prefix differences in the token concepts page #27562

Merged
merged 3 commits into from
Jun 26, 2024

Conversation

robmonte
Copy link
Member

@robmonte robmonte commented Jun 21, 2024

Description

Briefly explain Vault token prefixes in the concepts page.

TODO only if you're a HashiCorp employee

  • Labels: If this PR is the CE portion of an ENT change, and that ENT change is
    getting backported to N-2, use the new style backport/ent/x.x.x+ent labels
    instead of the old style backport/x.x.x labels.
  • Labels: If this PR is a CE only change, it can only be backported to N, so use
    the normal backport/x.x.x label (there should be only 1).
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

Closes #27151

@robmonte robmonte requested a review from a team as a code owner June 21, 2024 17:31
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jun 21, 2024
Copy link

CI Results:
All Go tests succeeded! ✅

Copy link

Build Results:
All builds succeeded! ✅

Copy link
Member

@tvoran tvoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a thought about recovery tokens, but 👍

website/content/docs/concepts/tokens.mdx Show resolved Hide resolved
@digital-content-events
Copy link

📄 Content Checks

Updated: Wed, 26 Jun 2024 22:55:33 GMT

Found 1 error(s)

content/docs/concepts/tokens.mdx

Position Description Rule
42:57-42:113 Unexpected product-relative link: /docs/concepts/recovery-mode#recovery-tokens. Ensure that relative links are fully-qualified Developer paths: /{productSlug}/docs/concepts/recovery-mode ensure-valid-link-format

@robmonte robmonte enabled auto-merge (squash) June 26, 2024 22:56
@robmonte robmonte merged commit 11bb553 into main Jun 26, 2024
25 of 27 checks passed
@robmonte robmonte deleted the add-token-prefix-section-token-concepts branch June 26, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.17.x hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog pr/no-milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document token format
2 participants