Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VAULT-28281: Pass in accountName variable into validation function #27563

Merged
merged 6 commits into from
Jun 21, 2024

Conversation

davidadeleon
Copy link
Contributor

Description

Solves Azure Storage Backend initialization issue due to invalid account name. The container name was being passed into the account name verification function which has the potential of violating Azure's storage account name requirements.

TODO only if you're a HashiCorp employee

  • [N/A] Labels: If this PR is the CE portion of an ENT change, and that ENT change is
    getting backported to N-2, use the new style backport/ent/x.x.x+ent labels
    instead of the old style backport/x.x.x labels.
  • [✅ ] Labels: If this PR is a CE only change, it can only be backported to N, so use
    the normal backport/x.x.x label (there should be only 1).
  • [N/A] ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • [✅ ] Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • [N/A] RFC: If this change has an associated RFC, please link it in the description.
  • [N/A] ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@davidadeleon davidadeleon added this to the 1.17.1 milestone Jun 21, 2024
@davidadeleon davidadeleon requested a review from a team June 21, 2024 17:36
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jun 21, 2024
Copy link

github-actions bot commented Jun 21, 2024

Build Results:
All builds succeeded! ✅

Copy link

github-actions bot commented Jun 21, 2024

CI Results:
All Go tests succeeded! ✅

physical/azure/azure.go Outdated Show resolved Hide resolved
@davidadeleon davidadeleon merged commit 45682dc into main Jun 21, 2024
83 checks passed
@davidadeleon davidadeleon deleted the davidadeleon/vault-28281 branch June 21, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.17.x hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants