Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare CE changes for [census.Agent] SetMetadata #27577

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Conversation

mpalmi
Copy link
Contributor

@mpalmi mpalmi commented Jun 24, 2024

Description

What does this PR do?

This PR adds the CE plumbing to prepare enterprise for the SetMetadata
API.

Enterprise PR: hashicorp/vault-enterprise#5955
Resolves: VAULT-27310

  • Labels: If this PR is the CE portion of an ENT change, and that ENT change is
    getting backported to N-2, use the new style backport/ent/x.x.x+ent labels
    instead of the old style backport/x.x.x labels.
  • Labels: If this PR is a CE only change, it can only be backported to N, so use
    the normal backport/x.x.x label (there should be only 1).
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

This PR adds the CE plumbing to prepare enterprise for the SetMetadata
API.

Enterprise PR: hashicorp/vault-enterprise#5955
Resolves: VAULT-27310
@mpalmi mpalmi added this to the 1.18.0-rc milestone Jun 24, 2024
@mpalmi mpalmi requested review from miagilepner and a team June 24, 2024 12:39
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jun 24, 2024
Copy link
Contributor

@miagilepner miagilepner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

Build Results:
All builds succeeded! ✅

Copy link

CI Results:
All Go tests succeeded! ✅

@mpalmi mpalmi requested a review from akshya96 June 24, 2024 14:37
Copy link
Contributor

@akshya96 akshya96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mpalmi mpalmi merged commit 93682b0 into main Jun 25, 2024
90 checks passed
@mpalmi mpalmi deleted the census/setmetadata branch June 25, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants